Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rails upgrade #366

Merged
merged 3 commits into from
Mar 31, 2021
Merged

rails upgrade #366

merged 3 commits into from
Mar 31, 2021

Conversation

banukutlu
Copy link
Contributor

@banukutlu banukutlu commented Mar 31, 2021 •
edited
Loading

Rails upgrade to 6.0.3.6, hopefully will address rails/rails#41750

Also upgraded rspec-rails to 5.0.x

@banukutlu banukutlu added this to the 1.0.x milestone Mar 31, 2021
@banukutlu banukutlu requested a review from cdmo March 31, 2021 17:02
@banukutlu banukutlu self-assigned this Mar 31, 2021
cdmo
cdmo previously approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@cdmo cdmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lotta code changes... wouldn't expect it in a dot release... ?

@banukutlu banukutlu force-pushed the rails-upgrade-6.0.3 branch from 5add64e to dd32bb0 Compare March 31, 2021 19:44
@banukutlu banukutlu requested a review from cdmo March 31, 2021 19:45
Banu Kutlu added 2 commits March 31, 2021 15:51
cdmo
cdmo approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@cdmo cdmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 🙆‍♂️

@cdmo cdmo merged commit 38913fc into main Mar 31, 2021
@cdmo cdmo deleted the rails-upgrade-6.0.3 branch March 31, 2021 20:24
banukutlu pushed a commit that referenced this pull request Apr 6, 2021
Rails bump (#366)
554726e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdmo cdmo cdmo approved these changes

Assignees

@banukutlu banukutlu

Labels
None yet
Projects
None yet
Milestone
1.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@banukutlu @cdmo